Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify generate-css.sh for changes in #1252 #1254

Merged
merged 2 commits into from
May 30, 2023
Merged

modify generate-css.sh for changes in #1252 #1254

merged 2 commits into from
May 30, 2023

Conversation

rszyma
Copy link
Contributor

@rszyma rszyma commented May 21, 2023

Description

To be merged along with #1252

@Finii
Copy link
Collaborator

Finii commented May 30, 2023

This is very good.

Well, you do not do what you yourself suggested, but that is not so important maybe:

Maybe we should add a disclaimer like "This file was autogenerated by . Do not edit." at the beginning of the autogenerated files so it's more obvious?

I believe people who mess with the files would need to find out how this all interacts anyhow, and have a look in the pony release.sh script or the workflows. Or the READMEs.

Approve, will be pulled when the other changes become ready. 👍

rszyma and others added 2 commits May 30, 2023 19:41
[why]
PR #1252 and this ran slightly out of sync.

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii
Copy link
Collaborator

Finii commented May 30, 2023

Rebase on master, force push

THIS web-merge is still broken :-(, resorting to manual

@Finii Finii merged commit 1b77115 into ryanoasis:master May 30, 2023
@rszyma rszyma deleted the update-cheatsheet-script branch May 30, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants